linux-kernel - Re: [PATCH] input: misc: don't build m68kspkr when mach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdV5um5L9WAk9pNEdQiTyT7YkQdgFRKH4vBqCwLPXsqPRw@mail.gmail.com>
Date:   Mon, 28 Aug 2017 19:15:46 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Greg Ungerer <gerg@...ux-m68k.org>,
        linux-m68k <linux-m68k@...ts.linux-m68k.org>,
        "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] input: misc: don't build m68kspkr when mach_beep is undefined

Hi Dmitry,

On Mon, Aug 28, 2017 at 6:50 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Thu, Aug 24, 2017 at 04:44:27PM +0200, Alexandre Belloni wrote:
>> mach_beep is defined arch/m68k/kernel/setup_mm.c which is compiled only
>> when MMU is selected.
>>
>> To avoid linking errors, make INPUT_M68K_BEEP depend on MMU.
>
> Hmm, can we maybe pull mach_beep from setup_mm.c to setup.c? MMU

Sounds OK to me. Greg?

> dependency seems to be artificial.

That's indeed artificial, it's really a platform dependency.
But currently these platforms (Amiga and Atari) do not support mmu-less
operation (yet).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds