linux-kernel - Re: [PATCH 0/6] perf tools: Minor build fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Aug 2017 11:31:34 -0700
From:   David Carrillo-Cisneros <davidcc@...gle.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Jiri Olsa <jolsa@...hat.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Stephane Eranian <eranian@...gle.com>,
        Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH 0/6] perf tools: Minor build fixes

On Mon, Aug 28, 2017 at 7:16 AM, Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
> Em Mon, Aug 28, 2017 at 11:34:21AM +0200, Jiri Olsa escreveu:
>> On Sun, Aug 27, 2017 at 12:54:36AM -0700, David Carrillo-Cisneros wrote:
>> > Collection of minor fixes to compile with LLVM and
>> > non-standard tool names.
>> >
>> > David Carrillo-Cisneros (6):
>> >   tools build tests: Don't hardcode gcc name
>> >   perf tools: Allow external definition of flex and bison binary names
>> >   tools lib: Allow external definition of CC, AR and LD
>> >   perf tools: Robustify detection of clang binary
>> >   perf tools: Remove BUG_ON char[] to bool implicit conversions
>> >   perf tools: Pass full path of FEATURES_DUMP
>>
>> apart from comment for 5/6 I'm ok with this
>>
>> Acked-by: Jiri Olsa <jolsa@...nel.org>
>
> Thanks, applied all that Jiri acked, agree with him that BUG should be
> avoided, and also that we should use existing facilities when available,
> and when there aren't, try to replicate as best as we can similar
> facilities existing in the kernel source code.

Thank you for applying them. I sent a new version of the one commented by Jiri.

David

>
> - Arnaldo