linux-kernel - Re: [PATCH] IPMI: make ipmi_poweroff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ada838fb-95fe-e122-8510-a158eb82dc44@acm.org>
Date:   Mon, 28 Aug 2017 13:40:00 -0500
From:   Corey Minyard <minyard@....org>
To:     Bhumika Goyal <bhumirks@...il.com>, julia.lawall@...6.fr,
        openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IPMI: make ipmi_poweroff_handler const

On 08/28/2017 01:08 PM, Bhumika Goyal wrote:
> Make this const as it is only passed to a const argument of the function
> ipmi_create_user.

Queued for the next kernel release.

-corey

> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>   drivers/char/ipmi/ipmi_poweroff.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_poweroff.c b/drivers/char/ipmi/ipmi_poweroff.c
> index 9f2e3be..cd0f41f 100644
> --- a/drivers/char/ipmi/ipmi_poweroff.c
> +++ b/drivers/char/ipmi/ipmi_poweroff.c
> @@ -133,7 +133,7 @@ static void receive_handler(struct ipmi_recv_msg *recv_msg, void *handler_data)
>   		complete(comp);
>   }
>   
> -static struct ipmi_user_hndl ipmi_poweroff_handler = {
> +static const struct ipmi_user_hndl ipmi_poweroff_handler = {
>   	.ipmi_recv_hndl = receive_handler
>   };
>