linux-kernel - RE: [PATCHv4 1/9] irqchip/ls-scfg-msi: fix typo of MSI compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM5PR0402MB277107C571183D2AF0E73EA5849F0@AM5PR0402MB2771.eurprd04.prod.outlook.com>
Date:   Tue, 29 Aug 2017 07:04:05 +0000
From:   "Z.q. Hou" <zhiqiang.hou@....com>
To:     "Z.q. Hou" <zhiqiang.hou@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "marc.zyngier@....com" <marc.zyngier@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "M.h. Lian" <minghuan.lian@....com>
Subject: RE: [PATCHv4 1/9] irqchip/ls-scfg-msi: fix typo of MSI compatible
 strings

Hi Thomas, Jason and Marc,

The version 4 patch set didn't get feedback for a long time, can you help to review it, and if there is no problem could you please help to apply it?

> -----Original Message-----
> From: Zhiqiang Hou [mailto:Zhiqiang.Hou@....com]
> Sent: 2017年7月5日 14:59
> To: linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; tglx@...utronix.de; jason@...edaemon.net;
> marc.zyngier@....com; robh+dt@...nel.org; mark.rutland@....com;
> linux@...linux.org.uk; shawnguo@...nel.org; M.h. Lian
> <minghuan.lian@....com>
> Cc: Z.q. Hou <zhiqiang.hou@....com>
> Subject: [PATCHv4 1/9] irqchip/ls-scfg-msi: fix typo of MSI compatible strings
> 
> From: Minghuan Lian <Minghuan.Lian@....com>
> 
> The patch is to fix typo of the Layerscape SCFG MSI dts compatible strings. "1"
> is replaced by "l".
> 
> Signed-off-by: Minghuan Lian <Minghuan.Lian@....com>
> Acked-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
> ---
> v4-v1:
>  - None
> 
>  .../devicetree/bindings/interrupt-controller/fsl,ls-scfg-msi.txt    | 6 +++---
>  drivers/irqchip/irq-ls-scfg-msi.c                                   | 6
> ++++--
>  2 files changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-scfg-msi.txt
> b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-scfg-msi.txt
> index 9e38949..2755cd1 100644
> ---
> a/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-scfg-msi.txt
> +++ b/Documentation/devicetree/bindings/interrupt-controller/fsl,ls-scfg
> +++ -msi.txt
> @@ -4,8 +4,8 @@ Required properties:
> 
>  - compatible: should be "fsl,<soc-name>-msi" to identify
>  	      Layerscape PCIe MSI controller block such as:
> -              "fsl,1s1021a-msi"
> -              "fsl,1s1043a-msi"
> +              "fsl,ls1021a-msi"
> +              "fsl,ls1043a-msi"
>  - msi-controller: indicates that this is a PCIe MSI controller node
>  - reg: physical base address of the controller and length of memory mapped.
>  - interrupts: an interrupt to the parent interrupt controller.
> @@ -23,7 +23,7 @@ MSI controller node
>  Examples:
> 
>  	msi1: msi-controller@...1000 {
> -		compatible = "fsl,1s1043a-msi";
> +		compatible = "fsl,ls1043a-msi";
>  		reg = <0x0 0x1571000 0x0 0x8>,
>  		msi-controller;
>  		interrupts = <0 116 0x4>;
> diff --git a/drivers/irqchip/irq-ls-scfg-msi.c b/drivers/irqchip/irq-ls-scfg-msi.c
> index 02cca74c..cef67cc 100644
> --- a/drivers/irqchip/irq-ls-scfg-msi.c
> +++ b/drivers/irqchip/irq-ls-scfg-msi.c
> @@ -219,8 +219,10 @@ static int ls_scfg_msi_remove(struct platform_device
> *pdev)  }
> 
>  static const struct of_device_id ls_scfg_msi_id[] = {
> -	{ .compatible = "fsl,1s1021a-msi", },
> -	{ .compatible = "fsl,1s1043a-msi", },
> +	{ .compatible = "fsl,1s1021a-msi", }, /* a typo */
> +	{ .compatible = "fsl,1s1043a-msi", }, /* a typo */
> +	{ .compatible = "fsl,ls1021a-msi", },
> +	{ .compatible = "fsl,ls1043a-msi", },
>  	{},
>  };
> 
> --
> 2.1.0.27.g96db324

Thanks,
Zhiqiang