linux-kernel - Re: [PATCH v3 0/3] Define CPU_BIG_ENDIAN or warn for inconsistencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170829090430.f6p3shucjxzicekw@hirez.programming.kicks-ass.net>
Date:   Tue, 29 Aug 2017 11:04:30 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Babu Moger <babu.moger@...cle.com>, ysato@...rs.sourceforge.jp,
        geert@...ux-m68k.org, jonas@...thpole.se,
        stefan.kristiansson@...nalahti.fi, shorne@...il.com,
        jejb@...isc-linux.org, deller@....de, davem@...emloft.net,
        viro@...iv.linux.org.uk, monstr@...str.eu, mpe@...erman.id.au,
        mingo@...hat.com, jcmvbkbc@...il.com, linux-kernel@...r.kernel.org,
        uclinux-h8-devel@...ts.sourceforge.jp, linux-m68k@...r.kernel.org,
        openrisc@...ts.librecores.org, linux-parisc@...r.kernel.org,
        sparclinux@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v3 0/3] Define CPU_BIG_ENDIAN or warn for inconsistencies

On Tue, Aug 29, 2017 at 08:30:15AM +0200, Greg KH wrote:
> On Thu, Jul 06, 2017 at 09:34:18AM -0700, Babu Moger wrote:
> > Resending the series per Greg KH's request.
> > 
> > Found this problem while enabling queued rwlock on SPARC.
> > The parameter CONFIG_CPU_BIG_ENDIAN is used to clear the
> > specific byte in qrwlock structure. Without this parameter,
> > we clear the wrong byte.
> > Here is the code in include/asm-generic/qrwlock.h
> > 
> > static inline u8 *__qrwlock_write_byte(struct qrwlock *lock)
> >   {
> >          return (u8 *)lock + 3 * IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN);
> >   }
> > 
> > Also found few more references of this parameter in
> > drivers/of/base.c
> > drivers/of/fdt.c
> > drivers/tty/serial/earlycon.c
> > drivers/tty/serial/serial_core.c
> > 
> > Here is our previous discussion.
> > https://lkml.org/lkml/2017/5/24/620
> > 
> > Based on the discussion, it was decided to add CONFIG_CPU_BIG_ENDIAN
> > for all the fixed big endian architecture(frv, h8300, m68k, openrisc,
> > parisc and sparc). And warn if there are inconsistencies in this definition.
> 
> Did this series ever get picked up by anyone?  I don't know whose tree
> it should go through if not, anyone have any ideas?  I guess I could,
> but arch-specific stuff is odd...

Seems like something that akpm would pick up, but it appears people
didn't actually Cc him.