linux-kernel - Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic compatible and rename file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a489dcc-e95c-bfe3-8e2a-fe2591fe86d8@cogentembedded.com>
Date:   Tue, 29 Aug 2017 13:08:09 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Mark Rutland <mark.rutland@....com>,
        Ian Campbell <ijc+devicetree@...lion.org.uk>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-usb@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH RESEND v2 3/3] dt-bindings: mt8173-mtu3: add generic
 compatible and rename file

Hello!

On 8/29/2017 12:20 PM, Chunfeng Yun wrote:

> The mt8173-mtu3.txt actually holds the bindings for all mediatek
> SoCs with usb3 DRD IP, so add a generic compatible and change the
> name to mediatek,mtu3.txt.
> 
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> Acked-by: Rob Herring <robh@...nel.org>
> ---
>   .../usb/{mt8173-mtu3.txt => mediatek,mtu3.txt}     |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>   rename Documentation/devicetree/bindings/usb/{mt8173-mtu3.txt => mediatek,mtu3.txt} (92%)
> 
> diff --git a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> similarity index 92%
> rename from Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> rename to Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> index b8ea394..722a029 100644
> --- a/Documentation/devicetree/bindings/usb/mt8173-mtu3.txt
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtu3.txt
> @@ -1,7 +1,11 @@
>   The device node for Mediatek USB3.0 DRD controller
>   
>   Required properties:
> - - compatible : should be "mediatek,mt8173-mtu3"
> + - compatible : should be "mediatek,soc-model-mtu3", "mediatek,mtu3",

    Worth enclosing soc-model in <>.

> +	soc-model is the name of SoC, such as mt8173, mt2712 etc,
> +	when using "mediatek,mtu3" compatible string, you need SoC specific
> +	ones in addition, one of:
> +	- "mediatek,mt8173-mtu3"
>    - reg : specifies physical base address and size of the registers
>    - reg-names: should be "mac" for device IP and "ippc" for IP port control
>    - interrupts : interrupt used by the device IP

MBR, Sergei