linux-kernel - Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170829102225.7yjh52hivygbdbc7@ninjato>
Date:   Tue, 29 Aug 2017 12:22:25 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Stephen Douthit <stephend@...engineering.com>
Cc:     seth.heasley@...el.com, nhorman@...driver.com,
        danp@...engineering.com, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] i2c: ismt: Fix length handling for SMBus block reads


> >> So basically the byte count already precedes the data in the dma_buffer,
> >> then the driver sticks desc->rxbytes in front of this resulting in the
> >> trace above.
> >>
> >> The first patch tackles this.
> >>
> >> The second patch in the series adds a sanity check on the byte count
> >> supplied by the slave device.  This might be a nice to have, but is
> >> probably less critical.
> > 
> > Both patches look good to me. Seth, Neil, do you agree?
> > 
> 
> Ping.
> 
> Not sure what the usual review time is, let me know if this is premature.

I applied both patches to for-next (v4.14) now to get a broader
audience. for-current (v4.13) might have been also applicable, but I
don't want to apply the patches there without the driver maintainer
acks. I hope this works for you.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)