linux-kernel - [PATCH 0/2] mtd: nand: fix regression introduced by splitting off manufacturer dependent code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1504001833-18097-1-git-send-email-LW@KARO-electronics.de>
Date:   Tue, 29 Aug 2017 12:17:11 +0200
From:   Lothar Waßmann <LW@...O-electronics.de>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Brian Norris <computersforpeace@...il.com>,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        David Woodhouse <dwmw2@...radead.org>,
        Marek Vasut <marek.vasut@...il.com>,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org
Subject: [PATCH 0/2] mtd: nand: fix regression introduced by splitting off manufacturer dependent code

commit c51d0ac59f24 ("mtd: nand: Move Samsung specific init/detection
logic in nand_samsung.c") introduced a regression for Samsung SLC NAND
chips by skipping the initialization of chip->bits_per_cell that is
done in nand_decode_ext_id() from which the manufacturer dependent
code was extracted.
The regression should also affect Hynix and Macronix chips whose code
was separated out in further commits but which I cannot test.
AMD/Spansion and Toshiba NAND are not affected, since they are calling 
nand_decode_ext_id() (which initializes bhip->bits_per_cell) in their
.detect function.

Fix the regression and add a warning to nand_is_slc() to prevent
further regressions of this kind.