linux-kernel - Re: [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Aug 2017 13:21:25 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Eric Anholt <eric@...olt.net>,
        Stefan Wahren <stefan.wahren@...e.com>,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH 9/9] clocksource/drivers/bcm2835: Remove message on memory
 allocation failure

I would prefer to use the wording “for a” instead of “on” in the commit subject.


> The bcm2835_timer_init() function emits an error message in case of a memory
> allocation failure. This is pointless as the mm core already do that.

Does this commit message contain a typo?
Would a wording like “… does that already.” be more appropriate here?

Regards,
Markus