linux-kernel - Re: [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170829114543.fftmrkiinhbyemsv@gmail.com>
Date:   Tue, 29 Aug 2017 13:45:43 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Hannes Reinecke <hare@...e.de>
Cc:     x86@...nel.org, Boris Petkov <bpetkov@...e.de>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Hannes Reinecke <hare@...e.com>
Subject: Re: [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST


* Hannes Reinecke <hare@...e.de> wrote:

> When COMPILE_TEST is set we should be compiling 32-bit only
> drivers and features (like ISA support etc), too.
> After all, it's a compile test.
> 
> Signed-off-by: Hannes Reinecke <hare@...e.com>
> ---
>  arch/x86/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 781521b7cf9e..df61bc37b1a2 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2548,7 +2548,7 @@ config ISA_DMA_API
>  	  Enables ISA-style DMA support for devices requiring such controllers.
>  	  If unsure, say Y.
>  
> -if X86_32
> +if X86_32 || COMPILE_TEST
>  
>  config ISA
>  	bool "ISA support"

This is almost certainly a bad idea: if it's a compile test, why not compile test 
the 32-bit kernel, which will include these drivers?

These are drivers that have probably been ever been built in 64-bit mode, and now 
an allmodconfig/allyesconfig will turn them on...

Thanks,

	Ingo