linux-kernel - Re: boot failure with 4.13.0-rc6 due to ATA errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170829142720.GI491396@devbig577.frc2.facebook.com>
Date:   Tue, 29 Aug 2017 07:27:20 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     David Ahern <dsahern@...il.com>, linux-ide@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Robert Elliott <elliott@....com>
Subject: Re: boot failure with 4.13.0-rc6 due to ATA errors

Hello,

On Tue, Aug 29, 2017 at 02:42:06PM +0200, Christoph Hellwig wrote:
> We could try to check the IDENTIFY DEVICE word, but given that it has
> a dual meaning in older spec versions I don't really like the idea
> either.  Untested patch below as I'm not near my OPAL capable drive.

I see.

> Also most recent ATA features seem to be keyed off a log page of some
> sort, so we'll run into more problems like this.

:(

> From e661047ec3a25587648b07c02a687a7dac778f3b Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@....de>
> Date: Tue, 29 Aug 2017 14:35:50 +0200
> Subject: libata: check for trusted computing in IDENTIFY DEVICE data
> 
> ATA-8 and later mirrors the TRUSTED COMPUTING SUPPORTED bit in word 48 of
> the IDENTIFY DEVICE data.  Check this before issuing a READ LOG PAGE
> command to avoid issues with buggy devices.  The only downside is that
> we can't support Security Send / Receive for a device with an older
> revision due to the conflicting use of this field in earlier
> specifications.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>

David, can you please see whether this patch resolves your issue?

Thanks.

-- 
tejun