linux-kernel - Re: [PATCH 3/3] cgroup: Implement cgroup2 basic CPU usage accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Aug 2017 08:42:36 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Waiman Long <longman@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>, lizefan@...wei.com,
        hannes@...xchg.org, mingo@...hat.com, cgroups@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-team@...com, pjt@...gle.com,
        luto@...capital.net, efault@....de, torvalds@...ux-foundation.org,
        guro@...com
Subject: Re: [PATCH 3/3] cgroup: Implement cgroup2 basic CPU usage accounting

Hello, Waiman.

On Tue, Aug 29, 2017 at 11:32:35AM -0400, Waiman Long wrote:
> > Also, please note that a system may end up with a lot of cgroups
> > without the user intending to.  memcg drains removed cgroups lazily
> > and the number of draining cgroups can reach very high numbers if the
> > system isn't under memory pressure.  The plan is to add basic stats
> > for other resources too and keeping it scalable w.r.t. idle cgroups
> > allows using the same mechanism for all resources.
> 
> I think it will be good to put the rationale behind this function as a
> comment in the code.

Ah, good point.  I'll beef up the overall comment in the header file
and point to that from the function comment.

Thanks.

-- 
tejun