linux-kernel - Re: [PATCH] i2c: busses: make i2c_adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170829203340.cl2uiuqoaikwsvmv@ninjato>
Date:   Tue, 29 Aug 2017 22:33:40 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, ludovic.desroches@...rochip.com,
        jochen@...am.de, vadimp@...lanox.com, michaelsh@...lanox.com,
        benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        andy.gross@...aro.org, david.brown@...aro.org,
        ldewangan@...dia.com, thierry.reding@...il.com,
        jonathanh@...dia.com, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH] i2c: busses: make i2c_adapter_quirks const

On Mon, Aug 21, 2017 at 05:42:04PM +0530, Bhumika Goyal wrote:
> Make these const as they are only stored as a reference in the quirks
> field of an i2c_adapter structure, which is const.
> 
> Done using Coccinelle:
> @match disable optional_qualifier@
> identifier s;
> @@
> static struct i2c_adapter_quirks s = {...};
> 
> @ref@
> position p;
> identifier match.s;
> @@
> s@p
> 
> @good1@
> identifier y;
> position ref.p;
> identifier match.s;
> @@
> struct i2c_adapter y = {...,.quirks=&s@p,...};
> 
> @good2@
> struct i2c_adapter y;
> identifier match.s;
> position ref.p;
> @@
> y.quirks = &s@p
> 
> @bad depends on  !good1 && !good2@
> position ref.p;
> identifier match.s;
> @@
> s@p
> 
> @depends on forall !bad disable optional_qualifier@
> identifier match.s;
> @@
> static
> + const
> struct i2c_adapter_quirks s;
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Removed the cocci script from the commit message and applied to
for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)