linux-kernel - Re: [PATCH v3] mfd: tps65217: Introduce dependency on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Aug 2017 10:05:42 +0200
From:   Javier Martinez Canillas <javier@...hile0.org>
To:     Keerthy <j-keerthy@...com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Enric Balletbò i Serra <eballetbo@...il.com>,
        "linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>,
        Tony Lindgren <tony@...mide.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH v3] mfd: tps65217: Introduce dependency on CONFIG_OF

Hello Keerthy,

On Wed, Aug 30, 2017 at 7:50 AM, Keerthy <j-keerthy@...com> wrote:
> Currently the driver boots only via device tree hence add a
> dependency on CONFIG_OF. This leaves with a bunch of unused code
> so clean that up. This patch also makes use of probe_new function
> in place of the probe function so as to avoid passing i2c_device_id.
>
> Signed-off-by: Keerthy <j-keerthy@...com>
> ---
>
> Changes in v3:
>
>   * Added more details to commit log.
>   * No changes in code. Rebased to latest next branch.
>
> Changes in v2:
>
>   * Cleaned up chip_id and data attached to the match.
>   * Cleaned up i2c_dev_id
>   * dropped the rest of the patches in series for now
>
> Boot tested and checked for regulator registrations on am335x-boneblack
>

Did you check building as a module? Autoload won't work if you remove
the I2C device ID table.

[snip]

>
> -static const struct i2c_device_id tps65217_id_table[] = {
> -       {"tps65217", TPS65217},
> -       { /* sentinel */ }
> -};
> -MODULE_DEVICE_TABLE(i2c, tps65217_id_table);
> -

Unfortunately this can't be removed yet. We are getting there but
still some patches need to land.

Rest of the patch looks good, so if you keep the I2C device ID table
feel free to add:

Reviewed-by: Javier Martinez Canillas <javierm@...hat.com>

Best regards,
Javier