linux-kernel - Re: [PATCH] mmc: mmci: stop building qcom dml as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8fc1458-2295-cdb3-d799-65d97c03ffe7@linaro.org>
Date:   Wed, 30 Aug 2017 13:20:30 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     Ulf Hansson <ulf.hansson@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: mmci: stop building qcom dml as module



>> -#ifdef CONFIG_MMC_QCOM_DML
>> +#if IS_ENABLED(CONFIG_MMC_QCOM_DML)
> 
> Because you change CONFIG_MMC_QCOM_DML beeing a bool instead of
> tristate, then I don't think you need to change this to IS_ENABLED().
> 
> Correct!?
Yep, that's correct Will respin the patch without this change


> 
>>   int dml_hw_init(struct mmci_host *host, struct device_node *np);
>>   void dml_start_xfer(struct mmci_host *host, struct mmc_data *data);
>>   #else
>> --
>> 2.9.3
>>
> 
> Otherwise this looks good to me.
> 
> Kind regards
> Uffe
>