linux-kernel - Re: [PATCH v3] ACPI / APEI: Suppress message if HEST not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878ti1gqqt.fsf@e105922-lin.cambridge.arm.com>
Date:   Wed, 30 Aug 2017 13:54:50 +0100
From:   Punit Agrawal <punit.agrawal@....com>
To:     "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Borislav Petkov <bp@...e.de>, linux-acpi@...r.kernel.org,
        lorenzo.pieralisi@....com, sudeep.holla@....com,
        linux-kernel@...r.kernel.org, James Morse <james.morse@....com>
Subject: Re: [PATCH v3] ACPI / APEI: Suppress message if HEST not present

"Rafael J. Wysocki" <rjw@...ysocki.net> writes:

> On Wednesday, August 30, 2017 12:34:55 PM CEST Punit Agrawal wrote:
>> Borislav Petkov <bp@...e.de> writes:
>> 
>> > On Tue, Aug 29, 2017 at 02:20:20PM +0100, Punit Agrawal wrote:
>> >> According to the ACPI specification, firmware is not required to provide
>> >> the Hardware Error Source Table (HEST). When HEST is not present, the
>> >> following superfluous message is printed to the kernel boot log -
>> >> 
>> >> [    3.460067] GHES: HEST is not enabled!
>> >> 
>> >> Extend hest_disable variable to track whether the firmware provides this
>> >> table and if it is not present skip any log output. The existing
>> >> behaviour is preserved in all other cases.
>> >> 
>> >> Suggested-by: Borislav Petkov <bp@...e.de>
>> >> Signed-off-by: Punit Agrawal <punit.agrawal@....com>
>> >> Cc: Borislav Petkov <bp@...e.de>
>> >> Cc: James Morse <james.morse@....com>
>> >> ---
>> >> 
>> >> Changes in v3:
>> >> * Grouped hest_disable status checking into a switch/case for clarity
>> >> 
>> >>  drivers/acpi/apei/ghes.c |  7 ++++++-
>> >>  drivers/acpi/apei/hest.c | 13 +++++++------
>> >>  include/acpi/apei.h      |  8 +++++++-
>> >>  3 files changed, 20 insertions(+), 8 deletions(-)
>> >
>> > Reviewed-by: Borislav Petkov <bp@...e.de>
>> 
>> Thanks!
>> 
>> Hopefully Rafael can pick the patch for the upcoming merge window.
>
> Applied already, should show up in linux-next tomorrow.

Neat! Thanks for picking up the patch.

>
> Thanks,
> Rafael
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html