linux-kernel - Re: [PATCH] fsnotify: make dnotify_fsnotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170830140305.GA5462@quack2.suse.cz>
Date:   Wed, 30 Aug 2017 16:03:05 +0200
From:   Jan Kara <jack@...e.cz>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, jack@...e.cz, amir73il@...il.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fsnotify: make dnotify_fsnotify_ops const

On Wed 30-08-17 18:09:02, Bhumika Goyal wrote:
> Make this const as it is never modified.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Thanks. Added to my tree.

								Honza

> ---
>  fs/notify/dnotify/dnotify.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/notify/dnotify/dnotify.c b/fs/notify/dnotify/dnotify.c
> index 2430a04..cba3283 100644
> --- a/fs/notify/dnotify/dnotify.c
> +++ b/fs/notify/dnotify/dnotify.c
> @@ -133,7 +133,7 @@ static void dnotify_free_mark(struct fsnotify_mark *fsn_mark)
>  	kmem_cache_free(dnotify_mark_cache, dn_mark);
>  }
>  
> -static struct fsnotify_ops dnotify_fsnotify_ops = {
> +static const struct fsnotify_ops dnotify_fsnotify_ops = {
>  	.handle_event = dnotify_handle_event,
>  	.free_mark = dnotify_free_mark,
>  };
> -- 
> 1.9.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR