linux-kernel - RE: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D8E82A446BF54499747901DBDEB737A8D0C199E@avsrvexchmbx1.microsemi.net>
Date:   Wed, 30 Aug 2017 02:10:55 +0000
From:   Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>
To:     Nikola Pajkovsky <npajkovsky@...e.cz>,
        dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>
CC:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from
 aac_convert_sgraw2()



> -----Original Message-----
> From: Nikola Pajkovsky [mailto:npajkovsky@...e.cz]
> Sent: Tuesday, August 29, 2017 4:59 AM
> To: dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>
> Cc: Nikola Pajkovsky <npajkovsky@...e.cz>; James E.J. Bottomley
> <jejb@...ux.vnet.ibm.com>; Martin K. Petersen
> <martin.petersen@...cle.com>; linux-scsi@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from
> aac_convert_sgraw2()
> 
> EXTERNAL EMAIL
> 
> 
> aac_convert_sgraw2() kmalloc memory and return -1 on error, which
> should be -ENOMEM. However, nobody is checking return value, so with
> this change, -ENOMEM is propagated to upper layer.
> 
> Signed-off-by: Nikola Pajkovsky <npajkovsky@...e.cz>
> ---
 [.....]
Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>