linux-kernel - Re: [PATCH 1/3] thunderbolt: Remove superfluous check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Aug 2017 16:25:51 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     "Bernat, Yehezkel" <yehezkel.bernat@...el.com>
Cc:     "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>,
        "andreas.noever@...il.com" <andreas.noever@...il.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "Jamet, Michael" <michael.jamet@...el.com>,
        "lukas@...ner.de" <lukas@...ner.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] thunderbolt: Remove superfluous check

On Wed, Aug 30, 2017 at 02:00:53PM +0000, Bernat, Yehezkel wrote:
> On Mon, 2017-08-28 at 16:20 +0200, Greg Kroah-Hartman wrote:
> > On Sun, Aug 27, 2017 at 04:31:27PM +0300, Mika Westerberg wrote:
> > > 
> > > On Tue, Aug 15, 2017 at 10:02:28AM +0300, Mika Westerberg wrote:
> > > > 
> > > > On Tue, Aug 15, 2017 at 08:19:01AM +0300, Bernat, Yehezkel wrote:
> > > > > 
> > > > > The key size is tested by hex2bin() already (as '\0' isn't an
> > > > > hex digit)
> > > > > 
> > > > > Suggested-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> > > > > Signed-off-by: Yehezkel Bernat <yehezkel.bernat@...el.com>
> > > > Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > > Hi Greg,
> > > 
> > > Do you have any comments regarding these patches? If not could you
> > > take
> > > them to your char-misc tree?
> > Will do, thanks.
> > 
> > greg k-h
> 
> Hi Greg,
> 
> I'm not sure if you intended to do so anyway, but I think it worth
> adding to v4.13, as these are fixes (and somewhat security related).

I didn't intend to, it's a bit late for 4.13, if you think these should
be backported, let stable@...r.kernel.org know the git commit ids when
they land in Linus's tree, and I'll be glad to backport them.

thanks,

greg k-h