linux-kernel - Re: [PATCH V1] regulator: pv88090: Exception handling for out of bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170830151223.nue35m3tdu3hfse3@sirena.org.uk>
Date:   Wed, 30 Aug 2017 16:12:24 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Eric Jeong <eric.jeong.opensource@...semi.com>
Cc:     LINUXKERNEL <linux-kernel@...r.kernel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH V1] regulator: pv88090: Exception handling for out of
 bounds

On Wed, Aug 30, 2017 at 05:54:27PM +0900, Eric Jeong wrote:

I've applied this but a few things to bear in mind for future
submissions:

> From: Eric Jeong <eric.jeong.opensource@...semi.com>

Please try to ensure that your e-mail address matches the one you use
for signoff, this avoids your mail looking like a non-author send that's
missing a signoff.

> This is a patch for exception handlding that the index of array is
> out of bounds. And the definitions have been updated to use
> proper device name.

This'd be easier to review with the rename separated out from the
functional change.

> @@ -43,7 +43,7 @@ enum {
>  struct pv88090_regulator {
>  	struct regulator_desc desc;
>  	/* Current limiting */
> -	unsigned	n_current_limits;
> +	unsigned int n_current_limits;

This is fine but it's an unrelated stylistic change.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)