linux-kernel - Re: [PATCH 06/16] fs: fix kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170830153859.GO5426@ZenIV.linux.org.uk>
Date:   Wed, 30 Aug 2017 16:39:00 +0100
From:   Al Viro <viro@...IV.linux.org.uk>
To:     Christoph Hellwig <hch@....de>
Cc:     arve@...roid.com, riandrews@...roid.com,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/16] fs: fix kernel_write prototype

On Wed, Aug 30, 2017 at 04:59:57PM +0200, Christoph Hellwig wrote:

>  	for (prot = 0; prot < prot_length;) {
>  		sector_t len = min_t(sector_t, bufsize, prot_length - prot);
> -		ssize_t ret = kernel_write(prot_fd, buf, len, pos + prot);
> +		ssize_t ret = kernel_write(prot_fd, buf, len, &pos);
>  
>  		if (ret != len) {
>  			pr_err("vfs_write to prot file failed: %zd\n", ret);
>  			return ret < 0 ? ret : -ENODEV;
>  		}
> -		prot += ret;
>  	}

And that loop will terminate because of...?  IOW, the same bug class as in
the kernel_read() patch.