linux-kernel - Re: [PATCH] qla2xxx: add missing includes for qla

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Aug 2017 17:15:20 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>
CC:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...ium.com>
Subject: Re: [PATCH] qla2xxx: add missing includes for qla_isr


> On Aug 30, 2017, at 6:12 AM, Johannes Thumshirn <jthumshirn@...e.de> wrote:
> 
> Since commit 7401bc18d1ee ("scsi: qla2xxx: Add FC-NVMe command handling")
> we make use of 'struct nvmefc_fcp_req' in qla24xx_nvme_iocb_entry() without
> including linux/nvme-fc-driver.h where it is defined.
> 
> Add linux/nvme-fc-driver.h (and scsi/fc/fc_fs.h as nvme-fc-driver.h needs
> the definition of 'struct fc_ba_rjt' from scsi/fc/fc_fs.h) to the header
> files included by qla_isr.c.
> 
> Fixes: 7401bc18d1ee ("scsi: qla2xxx: Add FC-NVMe command handling")
> Signed-off-by: Johannes Thumshirn <jthumshirn@...e.de>
> ---
> drivers/scsi/qla2xxx/qla_isr.c | 2 ++
> 1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c
> index 7b3b702ef622..b57cbe4ec32b 100644
> --- a/drivers/scsi/qla2xxx/qla_isr.c
> +++ b/drivers/scsi/qla2xxx/qla_isr.c
> @@ -14,6 +14,8 @@
> #include <scsi/scsi_tcq.h>
> #include <scsi/scsi_bsg_fc.h>
> #include <scsi/scsi_eh.h>
> +#include <scsi/fc/fc_fs.h>
> +#include <linux/nvme-fc-driver.h>
> 
> static void qla2x00_mbx_completion(scsi_qla_host_t *, uint16_t);
> static void qla2x00_status_entry(scsi_qla_host_t *, struct rsp_que *, void *);
> -- 
> 2.12.3
> 
Good catch. 

Acked-by: Himanshu Madhani <himanshu.madhani@...ium.com>

Thanks,
- Himanshu