linux-kernel - RE: [patch v1 0/3] drivers/platform: replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Aug 2017 19:33:46 +0000
From:   Vadim Pasternak <vadimp@...lanox.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Platform Driver" <platform-driver-x86@...r.kernel.org>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Jiří Pírko <jiri@...nulli.us>,
        Pavel Machek <pavel@....cz>
Subject: RE: [patch v1 0/3] drivers/platform: replace module
 x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug



> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Wednesday, August 30, 2017 10:32 PM
> To: Vadim Pasternak <vadimp@...lanox.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; linux-
> kernel@...r.kernel.org; Platform Driver <platform-driver-
> x86@...r.kernel.org>; Linux LED Subsystem <linux-leds@...r.kernel.org>;
> Jacek Anaszewski <jacek.anaszewski@...il.com>; Lee Jones
> <lee.jones@...aro.org>; Rob Herring <robh+dt@...nel.org>; Jiří Pírko
> <jiri@...nulli.us>; Pavel Machek <pavel@....cz>
> Subject: Re: [patch v1 0/3] drivers/platform: replace module x86/mlxcpld-
> hotplug with mellanox/mlxreg-hotplug
> 
> On Tue, Aug 29, 2017 at 9:02 PM, Vadim Pasternak <vadimp@...lanox.com>
> wrote:
> > The patchset modifies x86/mlxcpld-hotplug.c for making it architecture
> > independent, renames to mlxreg-hotplug and moves it from
> > drivers/platform/x86 folder to new drivers/platform/mellanox folder.
> > This modification also introduces regmap interface for mlxreg-hotplug
> > driver to allow hotplug event functionality over programmable devices
> > logic, when these devices can be attached to different interfaces
> > types, like I2C, LPC, SPI.
> > Module include/linux/platform_data/mlxcpld-hotplug.h is removed and
> > new module include/linux/platform_data/mlxreg.h is to be used instead.
> > Driver drivers/platform/x86/mlx-platform.c is updated according to new
> > interface.
> > Relevant Makefile and Kconfig are updated.
> >
> > This patchset depends on previously sent:
> > [patch v4 1/2] mfd: Add Mellanox regmap core driver because it
> > includes include/linux/platform_data/mlxreg.h from this patch.
> >
> 
> I'm fine with this from PDx86 prospective (since driver is going to be
> multiplatform).
> 
> While I'm giving you my...
> 
> Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 
> ...I would still like to have a consensus with Darren on it.
> 

Hi Andy,

Thank you very much for your reply.

Thanks,
Vadim.
> 
> > Vadim Pasternak (3):
> >   platform/mellanox: Introduce Mellanox hardware platform hotplug driver
> >   platform/x86: mlx-platform: modify hotplug device activation
> >   platform/x86: mlxcpld-hotplug: driver removing
> >
> >  MAINTAINERS                                   |  12 +-
> >  drivers/platform/Kconfig                      |   2 +
> >  drivers/platform/Makefile                     |   1 +
> >  drivers/platform/mellanox/Kconfig             |  25 +
> >  drivers/platform/mellanox/Makefile            |   1 +
> >  drivers/platform/mellanox/mlxreg-hotplug.c    | 712
> ++++++++++++++++++++++++++
> >  drivers/platform/x86/Kconfig                  |   9 -
> >  drivers/platform/x86/Makefile                 |   1 -
> >  drivers/platform/x86/mlx-platform.c           | 225 ++++++--
> >  drivers/platform/x86/mlxcpld-hotplug.c        | 515 -------------------
> >  include/linux/platform_data/mlxcpld-hotplug.h |  99 ----
> >  11 files changed, 918 insertions(+), 684 deletions(-)  create mode
> > 100644 drivers/platform/mellanox/Kconfig  create mode 100644
> > drivers/platform/mellanox/Makefile
> >  create mode 100644 drivers/platform/mellanox/mlxreg-hotplug.c
> >  delete mode 100644 drivers/platform/x86/mlxcpld-hotplug.c
> >  delete mode 100644 include/linux/platform_data/mlxcpld-hotplug.h
> >
> > --
> > 2.1.4
> >
> 
> 
> 
> --
> With Best Regards,
> Andy Shevchenko