linux-kernel - Re: [PATCH] vfio: platform: constify amba

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170830152436.7a06373a@w520.home>
Date:   Wed, 30 Aug 2017 15:24:36 -0600
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     b.reynal@...tualopensystems.com, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH] vfio: platform: constify amba_id

On Wed, 23 Aug 2017 22:47:15 +0530
Arvind Yadav <arvind.yadav.cs@...il.com> wrote:

> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/vfio/platform/vfio_amba.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c
> index 31372fb..62dfbfe 100644
> --- a/drivers/vfio/platform/vfio_amba.c
> +++ b/drivers/vfio/platform/vfio_amba.c
> @@ -93,7 +93,7 @@ static int vfio_amba_remove(struct amba_device *adev)
>  	return -EINVAL;
>  }
>  
> -static struct amba_id pl330_ids[] = {
> +static const struct amba_id pl330_ids[] = {
>  	{ 0, 0 },
>  };
>  

Applied to next branch for v4.14.  Thanks,

Alex