linux-kernel - Re: watchdog: ziirave: constify i2c_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Aug 2017 20:26:25 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     wim@...ana.be, linux-kernel@...r.kernel.org,
        linux-watchdog@...r.kernel.org
Subject: Re: watchdog: ziirave: constify i2c_device_id

On Mon, Aug 21, 2017 at 10:18:38PM +0530, Arvind Yadav wrote:
> i2c_device_id are not supposed to change at runtime. All functions
> working with i2c_device_id provided by <linux/i2c.h> work with
> const i2c_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/ziirave_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/ziirave_wdt.c b/drivers/watchdog/ziirave_wdt.c
> index b4e0cea..d3594aa 100644
> --- a/drivers/watchdog/ziirave_wdt.c
> +++ b/drivers/watchdog/ziirave_wdt.c
> @@ -737,7 +737,7 @@ static int ziirave_wdt_remove(struct i2c_client *client)
>  	return 0;
>  }
>  
> -static struct i2c_device_id ziirave_wdt_id[] = {
> +static const struct i2c_device_id ziirave_wdt_id[] = {
>  	{ "rave-wdt", 0 },
>  	{ }
>  };