lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Aug 2017 20:28:29 -0700 From: Guenter Roeck <linux@...ck-us.net> To: Arvind Yadav <arvind.yadav.cs@...il.com> Cc: tomas.winkler@...el.com, wim@...ana.be, linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org Subject: Re: watchdog: mei_wdt: constify mei_cl_device_id On Sat, Aug 26, 2017 at 11:41:06AM +0530, Arvind Yadav wrote: > mei_cl_device_id are not supposed to change at runtime. All functions > working with mei_cl_device_id provided by <linux/mei_cl_bus.h> work > with const mei_cl_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com> Reviewed-by: Guenter Roeck <linux@...ck-us.net> > --- > drivers/watchdog/mei_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/mei_wdt.c b/drivers/watchdog/mei_wdt.c > index b29c6fd..ea60b29 100644 > --- a/drivers/watchdog/mei_wdt.c > +++ b/drivers/watchdog/mei_wdt.c > @@ -670,7 +670,7 @@ static int mei_wdt_remove(struct mei_cl_device *cldev) > #define MEI_UUID_WD UUID_LE(0x05B79A6F, 0x4628, 0x4D7F, \ > 0x89, 0x9D, 0xA9, 0x15, 0x14, 0xCB, 0x32, 0xAB) > > -static struct mei_cl_device_id mei_wdt_tbl[] = { > +static const struct mei_cl_device_id mei_wdt_tbl[] = { > { .uuid = MEI_UUID_WD, .version = MEI_CL_VERSION_ANY }, > /* required last entry */ > { }
Powered by blists - more mailing lists