linux-kernel - Re: [PATCH v2] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <115727625.IkF9TZtNWN@aspire.rjw.lan>
Date:   Thu, 31 Aug 2017 01:29:24 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Yazen Ghannam <Yazen.Ghannam@....com>
Cc:     linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        lenb@...nel.org, linux-edac@...r.kernel.org, bp@...e.de,
        tony.luck@...el.com, Yazen Ghannam <yazen.ghannam@....com>
Subject: Re: [PATCH v2] ACPI, APEI, EINJ: Subtract any matching Register Region from Trigger resources

On Monday, August 28, 2017 8:13:14 PM CEST Yazen Ghannam wrote:
> From: Yazen Ghannam <yazen.ghannam@....com>
> 
> ACPI defines a number of instructions to use for triggering errors. However
> we are currently removing the address resources from the trigger resources
> for only the WRITE_REGISTER_VALUE instruction. This leads to a resource
> conflict for any other valid instruction.
> 
> Check that the instruction is less than or equal to the
> WRITE_REGISTER_VALUE instruction. This allows all valid memory access
> instructions and protects against invalid instructions.
> 
> Fixes: b4e008dc53a3 ("ACPI, APEI, EINJ, Refine the fix of resource conflict")
> Signed-off-by: Yazen Ghannam <yazen.ghannam@....com>
> Acked-by: Tony Luck <tony.luck@...el.com>
> ---
> Link:
> https://lkml.kernel.org/r/1502387883-16667-1-git-send-email-Yazen.Ghannam@amd.com
> 
> v1->v2:
> * Apply Tony's comment to restrict behavior to valid memory instructions.

Applied, thanks!