linux-kernel - Re: [PATCH 1/2] arm64: stacktrace: avoid listing stacktrace functions in stacktrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ce9206f-cffa-99c5-2a34-e5988bd0b603@codeaurora.org>
Date:   Thu, 31 Aug 2017 11:58:31 +0530
From:   Prakash Gupta <guptap@...eaurora.org>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     mhocko@...e.com, vbabka@...e.cz, will.deacon@....com,
        catalin.marinas@....com, iamjoonsoo.kim@....com,
        rmk+kernel@....linux.org.uk, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH 1/2] arm64: stacktrace: avoid listing stacktrace functions
 in stacktrace



On 8/31/2017 1:58 AM, Andrew Morton wrote:
> On Wed, 30 Aug 2017 13:02:22 +0530 Prakash Gupta <guptap@...eaurora.org> wrote:
> 
>> The stacktraces always begin as follows:
>>
>>   [<c00117b4>] save_stack_trace_tsk+0x0/0x98
>>   [<c0011870>] save_stack_trace+0x24/0x28
>>   ...
>>
>> This is because the stack trace code includes the stack frames for itself.
>> This is incorrect behaviour, and also leads to "skip" doing the wrong thing
>> (which is the number of stack frames to avoid recording.)
>>
>> Perversely, it does the right thing when passed a non-current thread.  Fix
>> this by ensuring that we have a known constant number of frames above the
>> main stack trace function, and always skip these.
>>
>> This was fixed for arch arm by Commit 3683f44c42e9 ("ARM: stacktrace: avoid
>> listing stacktrace functions in stacktrace")
> 
> I can take this (with acks, please?)
> 
> 3683f44c42e9 has a cc:stable but your patch does not.  Should it?
> 

My bad, it should be copied to stable as well.

> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
> 

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a 
member of the Code Aurora Forum, hosted by The Linux Foundation