linux-kernel - Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory Processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170831081820.GB9597@amd>
Date:   Thu, 31 Aug 2017 10:18:20 +0200
From:   Pavel Machek <pavel@....cz>
To:     Nikita Yushchenko <nikita.yoush@...entembedded.com>
Cc:     Andrey Smirnov <andrew.smirnov@...il.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Chris Healy <cphealy@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        Lee Jones <lee.jones@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jeff White <Jeff.White@....aero>
Subject: Re: [PATCH v6 1/2] platform: Add driver for RAVE Supervisory
 Processor

On Thu 2017-08-31 11:10:35, Nikita Yushchenko wrote:
> 
> 
> 30.08.2017 23:38, Pavel Machek wrote:
> > Hi!
> > 
> >>>> +                 * 9  -> Illegal Trap
> >>>> +                 * 10 -> Unknown
> >>>> +                 * 11 -> Crew Panel Requested
> >>>
> >>> Anyway... If you move management chip to .. I don't know, i2c, the
> >>> path would change. Also it would be different path on N900. Userland
> >>> should not have to deal with this.
> >>>
> >>> And... this should really be string, as the list will need to grow on
> >>> different hardware.
> >>
> >> I think we have a misunderstanding, with this part of the patch set I
> >> am not trying to propose a generic ABI that would be useful for any
> >> other driver but this one. Hence the lack of concern for different
> > 
> > Yes, but sorry, that's no-go.  Kernel should hide differences between
> > different machiens, and it should be rather easy in this case.
> 
> There is an interest to have reset reason exported on other ZII hardware
> as well.
> 
> I think that trying to make this generic is purely synthetic. This
> information is board-specific per it's nature, it comes from what board
> is designed for, different boards have quite different sets of possible
> reset reasons. What is needed is - pass this board-specific information
> to board-specific user space.
> 
> What's proper API for that, if not a sysfs attribute?

Please go through the thread.

Sysfs attribute is okay, but:

1) it should probably be a string

2) it should certainly be superset of all the reasons

3) it should be in generic place, say /sys/power/reset_reason

4) it should be documented what each state means
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)