linux-kernel - Re: [PATCH 1/4] phy: rcar-gen3-usb2: check dr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3a5b6050-01c6-1f92-7d79-42b74c692e3c@cogentembedded.com>
Date:   Thu, 31 Aug 2017 12:40:34 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, kishon@...com
Cc:     linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 1/4] phy: rcar-gen3-usb2: check dr_mode for otg mode

Hello!

On 8/31/2017 10:31 AM, Yoshihiro Shimoda wrote:

> The previous code assumed a channel has otg capability if a channel
> has interrupt property. But, it is not good because:
>   - Battery charging feature also needs interrupt property.
>   - Some R-Car Gen3 SoCs (e.g. R-Car D3) doesn't have OTG capability.

    Don't.

> So, this patch checks whether usb 2.0 host node has dr_mode property or
> not. If it has 'dr_mode = "otg";', this driver enables otg capability.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
[...]

MBR, Sergei