linux-kernel - Re: [PATCH] f2fs: constify super

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0820f21-01f0-1fd1-02b1-ffb62388f538@huawei.com>
Date:   Thu, 31 Aug 2017 18:56:48 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, <jaegeuk@...nel.org>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>
Subject: Re: [PATCH] f2fs: constify super_operations

On 2017/8/31 17:36, Arvind Yadav wrote:
> super_operations are not supposed to change at runtime.
> "struct super_block" working with super_operations provided
> by <linux/fs.h> work with const super_operations. So mark
> the non-const structs as const
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

> ---
>  fs/f2fs/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 32e4c02..2bf0869 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1199,7 +1199,7 @@ static inline void f2fs_quota_off_umount(struct super_block *sb)
>  }
>  #endif
>  
> -static struct super_operations f2fs_sops = {
> +static const struct super_operations f2fs_sops = {
>  	.alloc_inode	= f2fs_alloc_inode,
>  	.drop_inode	= f2fs_drop_inode,
>  	.destroy_inode	= f2fs_destroy_inode,
>