linux-kernel - Re: tunnels: Don't apply GRO to multiple layers of encapsulation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170831135840.GA19548@zipoli.concurrent-rt.com>
Date:   Thu, 31 Aug 2017 09:58:40 -0400
From:   joe.korty@...current-rt.com
To:     Jesse Gross <jesse@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: tunnels: Don't apply GRO to multiple layers of encapsulation.

[ resend due to mail problems at my end ]

Hi Jesse,

The backport of fac8e0f579695a3ecbc4d3cac369139d7f819971,
"tunnels: Don't apply GRO to multiple layers of encapsulation",
to linux-4.1.y seems to have missed a line.

The 4.1 commit is 066b300e5be43cb61697539e2a3a9aac5afb422f.

The potentially missing line is:

-               .gro_receive    = ipv6_gro_receive,
+               .gro_receive    = sit_gro_receive,

I am not experiencing any bad symptoms.  I simply noticed
that the patch introduced a new function, sit_gro_receive,
without introducing any users, and that same patch in  
linux-4.4.y does have a user.

Regards,
Joe