linux-kernel - Re: [PATCH] perf tools: Fix syntax in documentation of intel-pt config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170831163335.GF4831@kernel.org>
Date:   Thu, 31 Aug 2017 13:33:35 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jack Henschel <jackdev@...lbox.org>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix syntax in documentation of intel-pt
 config option

Em Thu, Aug 31, 2017 at 10:05:35AM +0200, Jack Henschel escreveu:
> As specified in tools/perf/Documentation/perf-config.txt, perf
> configuration items must be in 'key = value' format, otherwise the
> following error message occurs:
> 
> $ perf record -e intel_pt//u -- ls
> bad config file line 2 in ~/.perfconfig
> $ cat .perfconfig
> [intel-pt]
>     mispred-all
> 
> Changing assigning a value to the key 'mispred-all' fixes the issue:
> $ perf record -e intel_pt//u -- ls
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Capured and wrote 0.031 MB perf.data]
> $ cat .perfconfig
> [intel-pt]
>     mispred-all = true

You forgot to add your:

Signed-off-by: Jack Henschel <jackdev@...lbox.org>

I'm assuming you intended it, so I'm adding it to my local repository,
please ack this.

- Arnaldo

> ---
>  tools/perf/Documentation/intel-pt.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/Documentation/intel-pt.txt b/tools/perf/Documentation/intel-pt.txt
> index 4b6cdbf8f935..a47d845b9b61 100644
> --- a/tools/perf/Documentation/intel-pt.txt
> +++ b/tools/perf/Documentation/intel-pt.txt
> @@ -873,7 +873,7 @@ amended to take the number of elements as a parameter.
>  
>  	$ cat ~/.perfconfig
>  	[intel-pt]
> -		mispred-all
> +		mispred-all = on
>  
>  	$ perf record -e intel_pt//u ./sort 3000
>  	Bubble sorting array of 3000 elements
> -- 
> 2.14.1