linux-kernel - Re: [OpenRISC] [PATCH 01/13] openrisc: use shadow registers to save regs on exception

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170901082609.GH2609@lianli.shorne-pla.net>
Date:   Fri, 1 Sep 2017 17:26:09 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Jonas Bonn <jonas@...thpole.se>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Openrisc <openrisc@...ts.librecores.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [OpenRISC] [PATCH 01/13] openrisc: use shadow registers to save
 regs on exception

On Fri, Sep 01, 2017 at 10:03:44AM +0200, Geert Uytterhoeven wrote:
> On Fri, Sep 1, 2017 at 10:02 AM, Geert Uytterhoeven
> <geert@...ux-m68k.org> wrote:
> > On Wed, Aug 30, 2017 at 11:58 PM, Stafford Horne <shorne@...il.com> wrote:
> >> --- a/arch/openrisc/Kconfig
> >> +++ b/arch/openrisc/Kconfig
> >> @@ -121,6 +121,16 @@ config OPENRISC_NO_SPR_SR_DSX
> >>           Say N here if you know that your OpenRISC processor has
> >>           SPR_SR_DSX bit implemented. Say Y if you are unsure.
> >>
> >> +config OPENRISC_HAVE_SHADOW_GPRS
> >> +       bool "Support for shadow gpr files"
> >
> > default y if SMP?
> 
> Oops, that's not sufficient.
> 
> bool "Support for shadow gpr files" if !SMP
> default y if SMP

Thanks yes, the help text says its mandatory.  That should be forced as you
showed.

-Stafford

> >> +       help
> >> +         Say Y here if your OpenRISC processor features shadowed
> >> +         register files. They will in such case be used as a
> >> +         scratch reg storage on exception entry.
> >> +
> >> +         On SMP systems, this feature is mandatory.
> >> +         On a unicore system it's safe to say N here if you are unsure.
> >> +
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds