linux-kernel - Re: [PATCH 00/15] v5 kernel core pieces refcount conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170901094832.inwuzxczxs4b2ehh@hirez.programming.kicks-ass.net>
Date:   Fri, 1 Sep 2017 11:48:32 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Elena Reshetova <elena.reshetova@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Al Viro <viro@...iv.linux.org.uk>, Tejun Heo <tj@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Li Zefan <lizefan@...wei.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Eric Paris <eparis@...hat.com>, Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>, dvhart@...radead.org,
        "Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [PATCH 00/15] v5 kernel core pieces refcount conversions

On Thu, Aug 31, 2017 at 04:48:00PM -0700, Kees Cook wrote:
> On Wed, Aug 30, 2017 at 5:22 AM, Elena Reshetova
> <elena.reshetova@...el.com> wrote:
> > Now we have at least x86 support for ARCH_HAS_REFCOUNT merged and
> > arm and others on their way.
> >
> > Changes in v5:
> >  * Kees catched that the following changes in
> >    perf_event_context.refcount and futex_pi_state.refcount
> >    are not correct now when ARCH_HAS_REFCOUNT is enabled:
> >     -   WARN_ON(!atomic_inc_not_zero(refcount));
> >     +   refcount_inc(refcount);
> >    So they are now changed back to using refcount_inc_not_zero.
> 
> Thanks!
> 
> Reviewed-by: Kees Cook <keescook@...omium.org>
> 
> Andrew, are you able to carry these patches in -mm, since they span a
> bunch of core kernel areas?

No.. these patches should go through the regular trees that maintain
these various parts.