linux-kernel - Re: [PATCH 03/10] spi-nor: intel-spi: Fix broken software sequencing codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170901094553.GX2598@lahna.fi.intel.com>
Date:   Fri, 1 Sep 2017 12:45:53 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Bin Meng <bmeng.cn@...il.com>
Cc:     Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Marek Vasut <marek.vasut@...il.com>,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Brian Norris <computersforpeace@...il.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Stefan Roese <sr@...x.de>
Subject: Re: [PATCH 03/10] spi-nor: intel-spi: Fix broken software sequencing
 codes

On Fri, Sep 01, 2017 at 01:00:34AM -0700, Bin Meng wrote:
> There are two bugs in current intel_spi_sw_cycle():
> 
> - The 'data byte count' field should be the number of bytes
>   transferred minus 1
> - SSFSTS_CTL is the offset from ispi->sregs, not ispi->base
> 
> Signed-off-by: Bin Meng <bmeng.cn@...il.com>

This should be tagged for stable inclusion as well.