linux-kernel - Re: [PATCH 01/16] ashmem: switch to ->read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170901102034.GA25178@lst.de>
Date:   Fri, 1 Sep 2017 12:20:34 +0200
From:   Christoph Hellwig <hch@....de>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     Christoph Hellwig <hch@....de>, arve@...roid.com,
        riandrews@...roid.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/16] ashmem: switch to ->read_iter

On Wed, Aug 30, 2017 at 04:28:55PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:52PM +0200, Christoph Hellwig wrote:
> > And use the proper VFS helper for using the backing file.
> 
> Actually, I wonder if that update of ->f_pos of the underlying file is
> correct.  That's unrelated to this patch, but might be worth sorting
> out while we are at it.

Sure, I'll add that.  If ashmem_mutex wasn't a global lock we could
just as easily keep it locked, but I'll leave that to the android
folks.