linux-kernel - Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170901104141.GE25178@lst.de>
Date:   Fri, 1 Sep 2017 12:41:41 +0200
From:   Christoph Hellwig <hch@....de>
To:     Al Viro <viro@...IV.linux.org.uk>
Cc:     Christoph Hellwig <hch@....de>, arve@...roid.com,
        riandrews@...roid.com, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/16] mm/nommu: switch do_mmap_private to kernel_read

On Wed, Aug 30, 2017 at 04:41:28PM +0100, Al Viro wrote:
> On Wed, Aug 30, 2017 at 04:59:59PM +0200, Christoph Hellwig wrote:
> > -		fpos = vma->vm_pgoff;
> > -		fpos <<= PAGE_SHIFT;
> 
> > +		loff_t fpos = vma->vm_pgoff << PAGE_SHIFT;
> 
> Umm...  Are you sure it's OK on 32bit hosts?

It's not.  Fixed.