linux-kernel - Re: [PATCH][staging-next] staging: typec: fusb302: make structure fusb302_psy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170901142023.GA599@roeck-us.net>
Date:   Fri, 1 Sep 2017 07:20:24 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Colin King <colin.king@...onical.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Yueyao Zhu <yueyao.zhu@...il.com>,
        Rui Miguel Silva <rmfrfs@...il.com>,
        Guru Das Srinagesh <gurooodas@...il.com>,
        Frans Klaver <fransklaver@...il.com>,
        devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][staging-next] staging: typec: fusb302: make structure
 fusb302_psy_desc static

On Fri, Sep 01, 2017 at 11:20:57AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The const structure fusb302_psy_desc is local to the source and
> does not need to be in global scope, so make it static.
> 
> Cleans up sparse warnings
> symbol 'fusb302_psy_desc' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/staging/typec/fusb302/fusb302.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
> index cf6355f59cd9..fc6a3cf74eb3 100644
> --- a/drivers/staging/typec/fusb302/fusb302.c
> +++ b/drivers/staging/typec/fusb302/fusb302.c
> @@ -1723,7 +1723,7 @@ static enum power_supply_property fusb302_psy_properties[] = {
>  	POWER_SUPPLY_PROP_CURRENT_MAX,
>  };
>  
> -const struct power_supply_desc fusb302_psy_desc = {
> +static const struct power_supply_desc fusb302_psy_desc = {
>  	.name		= "fusb302-typec-source",
>  	.type		= POWER_SUPPLY_TYPE_USB_TYPE_C,
>  	.properties	= fusb302_psy_properties,
> -- 
> 2.14.1
>