lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 01 Sep 2017 10:34:08 -0700 (PDT) From: David Miller <davem@...emloft.net> To: colin.king@...onical.com Cc: harish.patil@...ium.com, manish.chopra@...ium.com, Dept-GELinuxNICDev@...ium.com, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] qlcnic: remove redundant zero check on retries counter From: Colin King <colin.king@...onical.com> Date: Fri, 1 Sep 2017 14:44:31 +0100 > From: Colin Ian King <colin.king@...onical.com> > > At the end of the do while loop the integer counter retries will > always be zero and so the subsequent check to see if it is zero > is always true and therefore redundant. Remove the redundant check > and always return -EIO on this return path. Also unbreak the literal > string in dev_err message to clean up a checkpatch warning. > > Detected by CoverityScan, CID#744279 ("Logically dead code") > > Signed-off-by: Colin Ian King <colin.king@...onical.com> Applied to net-next, thanks.
Powered by blists - more mailing lists