linux-kernel - Re: [alsa-devel] [PATCH v6 01/12] ALSA: ac97: split out the generic ac97 registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hy3pwuubs.wl-tiwai@suse.de>
Date:   Sun, 03 Sep 2017 09:15:03 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
        alsa-devel@...a-project.org, patches@...nsource.wolfsonmicro.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-input@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH v6 01/12] ALSA: ac97: split out the generic    ac97 registers

On Sat, 02 Sep 2017 21:54:03 +0200,
Robert Jarzmik wrote:
> 
> Split out from the ac97_codec.h the ac97 generic registers, which can be
> used by a codec, typically a generic ac97 codec, and by the ac97 bus, to
> scan an ac97 AC-Link.
> 
> This split encompasses all the AC97 standard registers, but not the
> codec specific ones.
> 
> In order to have a clean split between former ac97 bus implementation
> and the new coming one in sound/ac97, it is safer to not include any
> former ac97 includes, excepting in sound/ac97/compat.c.
> 
> Amongst the thing to isolate :
>  - don't have the struct snd_ac97 in sound/ac97/* (except compat.c) to not
>    be "fooled" by a definition which would come with ac97_codec.h by
>    "chance".
>  - don't have to have snd_a97_*() functions, as they rely on struct
>    snd_ac97.
>   - don't want the struct snd_ac97_bus_ops, there is a new one
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>

Reviewed-by: Takashi Iwai <tiwai@...e.de>


thanks,

Takashi