linux-kernel - Re: [PATCH v2 1/2] ARM: dts: sun8i: h3: Enable AP6212 WiFi on mmc1 on Nanopi M1 Plus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170904080415.ptgjnkjwtdthp7ds@flea>
Date:   Mon, 4 Sep 2017 10:04:15 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     icenowy@...c.io
Cc:     Philipp Rossak <embed3d@...il.com>, robh+dt@...nel.org,
        mark.rutland@....com, linux@...linux.org.uk, wens@...e.org,
        devicetree@...r.kernel.org, linux-sunxi@...glegroups.com,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] ARM: dts: sun8i: h3: Enable AP6212 WiFi on mmc1
 on Nanopi M1 Plus

On Sat, Sep 02, 2017 at 03:01:57PM +0800, icenowy@...c.io wrote:
> 在 2017-09-02 00:30，Philipp Rossak 写道：
> > From: Philipp Rossak <embed3d@...il.com>
> > 
> > The WiFi side of the AP6212 WiFi/BT combo module is connected to
> > mmc1. There are also GPIOs for enable and interrupts.
> > 
> > Enable WiFi on this board by enabling mmc1 and adding the power
> > sequencing clocks and GPIO, as well as the chip's interrupt line.
> > 
> > Signed-off-by: Philipp Rossak <embed3d@...il.com>
> > ---
> >  arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts | 25
> > +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts
> > b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts
> > index 6256f55..7d18c35 100644
> > --- a/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts
> > +++ b/arch/arm/boot/dts/sun8i-h3-nanopi-m1-plus.dts
> > @@ -48,6 +48,13 @@
> > 
> >  	aliases {
> >  		serial1 = &uart3;
> > +		ethernet1 = &sdio_wifi;
> 
> When the Wi-Fi module itself has fixed MAC address, there's
> no need for such an alias.

But the description is also accurate, which is what matters in the DT.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)