linux-kernel - [PATCH] checkpatch: simplify the output of --list-types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170904100824.4cc2410a@endymion>
Date:   Mon, 4 Sep 2017 10:08:24 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] checkpatch: simplify the output of --list-types

Drop the header and numbering of types. This format was confusing as
it suggested one could pass the number instead of the type name,
however it did not actually work, and numbering wasn't stable anyway.

Signed-off-by: Jean Delvare <jdelvare@...e.de>
Cc: Andy Whitcroft <apw@...onical.com>
Cc: Joe Perches <joe@...ches.com>
---
 scripts/checkpatch.pl |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- linux-4.13-rc7.orig/scripts/checkpatch.pl	2017-09-04 08:51:13.234841824 +0200
+++ linux-4.13-rc7/scripts/checkpatch.pl	2017-09-04 10:07:11.994427535 +0200
@@ -134,8 +134,6 @@ sub uniq {
 sub list_types {
 	my ($exitcode) = @_;
 
-	my $count = 0;
-
 	local $/ = undef;
 
 	open(my $script, '<', abs_path($P)) or
@@ -150,9 +148,8 @@ sub list_types {
 		push (@types, $_);
 	}
 	@types = sort(uniq(@types));
-	print("#\tMessage type\n\n");
 	foreach my $type (@types) {
-		print(++$count . "\t" . $type . "\n");
+		print "$type\n";
 	}
 
 	exit($exitcode);

-- 
Jean Delvare
SUSE L3 Support