linux-kernel - Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to update inode checksum for recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74132304-3604-c9b6-b618-7cc5ea7d6a49@huawei.com>
Date:   Mon, 4 Sep 2017 09:26:12 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-fsdevel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: don't need to update inode checksum
 for recovery

On 2017/9/2 1:25, Jaegeuk Kim wrote:
> This patch fixes "f2fs: support inode checksum".
> The recovered inode page will be rewritten with valid checksum.
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

> ---
>  fs/f2fs/node.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 2654c9166fba..388a00262a5f 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -2287,8 +2287,6 @@ int recover_inode_page(struct f2fs_sb_info *sbi, struct page *page)
>  			F2FS_FITS_IN_INODE(src, le16_to_cpu(src->i_extra_isize),
>  								i_projid))
>  			dst->i_projid = src->i_projid;
> -
> -		f2fs_inode_chksum_set(sbi, ipage);
>  	}
>  
>  	new_ni = old_ni;
>