linux-kernel - Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170904101849.7uefwhuqz4vtntrp@localhost.localdomain>
Date:   Mon, 4 Sep 2017 11:18:49 +0100
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Robert Jarzmik <robert.jarzmik@...e.fr>
CC:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>, Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
        <linux-kernel@...r.kernel.org>, <linux-input@...r.kernel.org>,
        <patches@...nsource.wolfsonmicro.com>,
        <alsa-devel@...a-project.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v6 09/12] ASoC: wm9712: add ac97 new bus support

On Sat, Sep 02, 2017 at 09:54:11PM +0200, Robert Jarzmik wrote:
> Add support for the new ac97 bus model, where devices are automatically
> discovered on AC-Links.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> ---
> Since v4:
>  - added #ifdef spotted by Charles
> ---
>  	snd_soc_codec_init_regmap(codec, regmap);
> @@ -666,7 +677,8 @@ static int wm9712_soc_remove(struct snd_soc_codec *codec)
>  	struct wm9712_priv *wm9712 = snd_soc_codec_get_drvdata(codec);
>  
>  	snd_soc_codec_exit_regmap(codec);
> -	snd_soc_free_ac97_codec(wm9712->ac97);
> +	if (!wm9712->mfd_pdata)
> +		snd_soc_free_ac97_codec(wm9712->ac97);

This bit is still missing the ifdef it has in the preceeding
patch.

Otherwise looks good to me.

Thanks,
Charles