linux-kernel - Re: [PATCH v2] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170904115322.GB2477@lahna.fi.intel.com>
Date:   Mon, 4 Sep 2017 14:53:22 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     "Rafael J . Wysocki" <rjw@...ysocki.net>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        linux-acpi@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] platform/x86: intel_cht_int33fe: Work around BIOS bug
 on some devices

On Sat, Sep 02, 2017 at 06:20:40PM +0200, Hans de Goede wrote:
> At least one BIOS enumerates the max17047 both through the INT33FE ACPI
> device (it is right there in the resources table) as well as through a
> separate MAX17047 device.
> 
> This commit checks for the max17047 already being enumerated through
> a separate MAX17047 ACPI device and if so it uses the i2c-client
> instantiated for this and attaches the device-props for the max17047 to
> that i2c-client.
> 
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>

I won't say this looks good to me, but since this seems to be the only
sane way to deal with the crappy BIOS,

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>