linux-kernel - Re: [PATCH v2 15/18] clk: add support for clocks provided by SCMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51391c6f-2c20-119e-f8d4-cc4800c79124@arm.com>
Date:   Mon, 4 Sep 2017 14:37:14 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Stephen Boyd <sboyd@...eaurora.org>
Cc:     Sudeep Holla <sudeep.holla@....com>,
        ALKML <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        Roy Franz <roy.franz@...ium.com>,
        Harb Abdulhamid <harba@...eaurora.org>,
        Nishanth Menon <nm@...com>, Arnd Bergmann <arnd@...db.de>,
        Loc Ho <lho@....com>, Alexey Klimov <alexey.klimov@....com>,
        Ryan Harkin <Ryan.Harkin@....com>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 15/18] clk: add support for clocks provided by SCMI



On 01/09/17 01:19, Stephen Boyd wrote:
> On 08/04, Sudeep Holla wrote:
>> diff --git a/drivers/clk/clk-scmi.c b/drivers/clk/clk-scmi.c
>> new file mode 100644
>> index 000000000000..37f98a6439a0
>> --- /dev/null
>> +++ b/drivers/clk/clk-scmi.c

[...]

>> +static int scmi_clocks_probe(struct platform_device *pdev)
>> +{
>> +	struct device *dev = &pdev->dev;
>> +	struct device_node *np = dev->of_node;
>> +	const struct scmi_handle *handle = devm_scmi_handle_get(dev);
>> +
>> +	if (IS_ERR_OR_NULL(handle) || !handle->clk_ops)
>> +		return -EPROBE_DEFER;
>> +
>> +	return scmi_clk_add(dev, np, handle);
> 
> Why the function? We support more than just platform devices?
> Just fold scmi_clk_add() into this function instead please.
> 

All valid points. Fixed locally now, will post as part of next posting
of the series.

-- 
Regards,
Sudeep