linux-kernel - Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e89bf21-6b4a-d721-e747-f8dab016b58a@st.com>
Date:   Mon, 4 Sep 2017 13:56:03 +0000
From:   Philippe CORNU <philippe.cornu@...com>
To:     Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Alexandre TORGUE <alexandre.torgue@...com>,
        Fabien DESSENNE <fabien.dessenne@...com>,
        Yannick FERTRE <yannick.fertre@...com>,
        "Maxime Coquelin" <mcoquelin.stm32@...il.com>,
        Mickael REULIER <mickael.reulier@...com>,
        Vincent ABRIOU <vincent.abriou@...com>,
        "Gabriel FERNANDEZ" <gabriel.fernandez@...com>,
        Ludovic BARRE <ludovic.barre@...com>
Subject: Re: [PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request
 exclusive reset control



On 09/04/2017 01:40 PM, Archit Taneja wrote:
> 
> 
> On 09/01/2017 07:15 PM, Andrzej Hajda wrote:
>> On 01.08.2017 15:23, Philippe CORNU wrote:
>>> Based on patch "Convert drivers to explicit reset API" from Philipp 
>>> Zabel
>>>
>>> Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting
>>> reset lines") started to transition the reset control request API calls
>>> to explicitly state whether the driver needs exclusive or shared reset
>>> control behavior. Convert all drivers requesting exclusive resets to the
>>> explicit API call so the temporary transition helpers can be removed.
>>>
>>> No functional changes.
>>>
>>> Cc: Philipp Zabel <p.zabel@...gutronix.de>
>>> Signed-off-by: Philippe CORNU <philippe.cornu@...com>
>>> Acked-by: Philipp Zabel <p.zabel@...gutronix.de>
>>> ---
>>>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 10 +++-------
>>>   1 file changed, 3 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c 
>>> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> index 781340d..4e1f91e 100644
>>> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
>>> @@ -885,15 +885,11 @@ static int dw_mipi_dsi_bridge_attach(struct 
>>> drm_bridge *bridge)
>>>        * Note that the reset was not defined in the initial device 
>>> tree, so
>>>        * we have to be prepared for it not being found.
>>>        */
>>> -    apb_rst = devm_reset_control_get(dev, "apb");
>>> +    apb_rst = devm_reset_control_get_optional_exclusive(dev, "apb");
>>>       if (IS_ERR(apb_rst)) {
>>>           ret = PTR_ERR(apb_rst);
>>> -        if (ret == -ENOENT) {
>>> -            apb_rst = NULL;
>>> -        } else {
>>> -            dev_err(dev, "Unable to get reset control: %d\n", ret);
>>> -            return ERR_PTR(ret);
>>> -        }
>>> +        dev_err(dev, "Unable to get reset control: %d\n", ret);
>>
>> I think in case of deferred probing it shouldn't be dev_err, but this is
>> rather suggestion.
>>
>>> +        return ERR_PTR(ret);
>> return apb_rst;
>>
>> With this fixed:
>> Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>
> 
> queued to drm-misc-next after incorporating Andrzej's comment.
> 

Dears Archit & Andrzej,
A big *THANK YOU* for review/rework/integration,
Philippe :-)

>>
>>   --
>> Regards
>> Andrzej
>>
>>>       }
>>>       if (apb_rst) {
>>
>>
>