linux-kernel - Re: [PATCH v2] ALSA: hda: Fix forget to free resource in error handling code path in hda_codec_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5ha82apjeb.wl-tiwai@suse.de>
Date:   Mon, 04 Sep 2017 17:34:36 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Wang YanQing <udknight@...il.com>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] ALSA: hda: Fix forget to free resource in error handling code path in hda_codec_driver_probe

On Mon, 04 Sep 2017 17:17:09 +0200,
Wang YanQing wrote:
> 
> When hda_codec_driver_probe meet error and return failure, we need
> to free resource with patch_ops.free, or we will get resource leak.
> 
> Signed-off-by: Wang YanQing <udknight@...il.com>
> ---
>  Changes v1-v2:
>  1: Fix calling patch_ops.free after module_put, reported by Takashi Iwai.
> 
>  Hi! Takashi Iwai
>  Because the only one calling site of patch_ops.free is in
>  hda_codec_driver_remove, and if hda_codec_driver_probe return
>  failure, we will no chance to call the hda_codec_driver_remove,
>  so I think we don't need to care below case:
>  "Or, for safety, we may put an internal flag to indicate that the codec
>   free got already called, and check it at before calling
>   patch_ops.free, too."

Fair enough, applied now.

I found patch_ca0132.c still misses the free at the error path in its
probe function, so I'll fix it.

thanks,

Takashi