linux-kernel - Re: [PATCH 06/13] perf vendor events powerpc: Remove duplicate events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170904165106.GT2482@two.firstfloor.org>
Date:   Mon, 4 Sep 2017 09:51:06 -0700
From:   Andi Kleen <andi@...stfloor.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
        linux-perf-users@...r.kernel.org,
        Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
        Andi Kleen <andi@...stfloor.org>,
        Anton Blanchard <anton@....ibm.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH 06/13] perf vendor events powerpc: Remove duplicate events

On Mon, Sep 04, 2017 at 11:00:37AM -0300, Arnaldo Carvalho de Melo wrote:
> From: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>
> 
> Some POWER PMU event names have multiple/alternate event codes. These
> alternate event codes were listed in the POWER9 JSON files for
> reference.
> 
> But the perf tool does not seem to handle duplicates cleanly. 'perf
> list' shows such duplicate events only once, but 'perf stat' ends up
> counting the first event code twice, multiplexing if necessary and we
> end up with double the event counts.
> 
> Remove the duplicate event codes from the JSON files for now.

It would be better to fix it in perf. I assume it wouldn't be that hard.
Intel may get multiple versions of events at some point too,
as events get renamed, but the old names stay around for compatibility.

-Andi